• dark_stang@beehaw.org
    link
    fedilink
    English
    arrow-up
    9
    ·
    11 months ago

    I joined a team years ago where everyone would catch exceptions then throw a different exception in the catch, swallowing the original. Sometimes these were nested many layers. Troubleshooting was a nightmare.

    I spent a week deleting all of them and told everybody that “try” was now a forbidden word outside of entry points.

    • lobut@lemmy.ca
      link
      fedilink
      arrow-up
      5
      ·
      11 months ago

      I remember doing that as a junior because everyone in our codebase did it!

      My new team lead came in and asked me why. I said it’s to reformat it due to the layer it was in. He said “…and what did you really accomplish with that?” All we did was bury our real error really well. It made me think about these things and to question convention more